Refactor: confine Saxon references to the deferred-loading configurer - #52
Merged
garydgregory merged 1 commit intoAug 26, 2026
Merged
Conversation
Move the EmptySource::getInstance reference into SaxonProviderConfigurer, so every Saxon symbolic reference lives in the nested class and the outer class verifies without Saxon on the classpath; document that role on the nested class. Drop the LinkageError guards in the two configure methods: a missing Saxon cannot reach them (the isSaxon gate guarantees a loaded Saxon-package class), and for an incompatible Saxon version letting the LinkageError propagate matches JAXP's own ConfigurationError convention. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jvd3SdALeiMvRPBe3Y7Cdp
ppkarwasz
force-pushed
the
refactor/saxon-provider-boundary
branch
from
August 26, 2026 17:27
52ad8fb to
051ee9f
Compare
garydgregory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
EmptySource::getInstancereference intoSaxonProviderConfigurer, so every Saxon symbolic reference lives in the nested class and the outer class verifies without Saxon on the classpath.Drop the
LinkageErrorguards in the two configure methods: a missing Saxon cannot reach them (theisSaxongate guarantees a loaded Saxon-package class), and for an incompatible Saxon version letting theLinkageErrorpropagate matches JAXP's ownConfigurationErrorconvention.